From da248a8b47114226cbf050f4da4739936df2f791 Mon Sep 17 00:00:00 2001 From: fhanik Date: Thu, 21 Feb 2008 16:06:17 +0000 Subject: [PATCH] modify test code to report more info avoid concurrency during closedown git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@629843 13f79535-47bb-0310-9956-ffa450edef68 --- java/org/apache/catalina/tribes/transport/nio/NioReceiver.java | 4 ++-- test/org/apache/catalina/tribes/test/channel/TestUdpPackages.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/java/org/apache/catalina/tribes/transport/nio/NioReceiver.java b/java/org/apache/catalina/tribes/transport/nio/NioReceiver.java index 0c91f1f69..d166b166d 100644 --- a/java/org/apache/catalina/tribes/transport/nio/NioReceiver.java +++ b/java/org/apache/catalina/tribes/transport/nio/NioReceiver.java @@ -281,7 +281,7 @@ public class NioReceiver extends ReceiverBase implements Runnable, ChannelReceiv // get an iterator over the set of selected keys Iterator it = selector.selectedKeys().iterator(); // look at each key in the selected set - while (it.hasNext()) { + while (it.hasNext() && selector!=null) { SelectionKey key = (SelectionKey) it.next(); // Is a new connection coming in? if (key.isAcceptable()) { @@ -310,7 +310,7 @@ public class NioReceiver extends ReceiverBase implements Runnable, ChannelReceiv } // remove key from selected set, it's been handled - it.remove(); + if (selector!=null) it.remove(); } } catch (java.nio.channels.ClosedSelectorException cse) { // ignore is normal at shutdown or stop listen socket diff --git a/test/org/apache/catalina/tribes/test/channel/TestUdpPackages.java b/test/org/apache/catalina/tribes/test/channel/TestUdpPackages.java index dc4f39a73..3197ebd94 100644 --- a/test/org/apache/catalina/tribes/test/channel/TestUdpPackages.java +++ b/test/org/apache/catalina/tribes/test/channel/TestUdpPackages.java @@ -104,9 +104,9 @@ public class TestUdpPackages extends TestCase { try { long start = System.currentTimeMillis(); for (int i = 0; i < msgCount; i++) { - int cnt = counter.addAndGet(1); + int cnt = counter.getAndAdd(1); channel1.send(new Member[] {channel2.getLocalMember(false)}, Data.createRandomData(1024,cnt),Channel.SEND_OPTIONS_UDP); - Thread.currentThread().sleep(10); + //Thread.currentThread().sleep(10); } System.out.println("Thread["+this.getName()+"] sent "+msgCount+" messages in "+(System.currentTimeMillis()-start)+" ms."); }catch ( Exception x ) { -- 2.11.0