From e2a25545f4814c7ae1b0fb3f56e467957621bc7f Mon Sep 17 00:00:00 2001
From: "Michael J. Rubinsky" <mrubinsk@horde.org>
Date: Wed, 31 Mar 2010 14:12:07 -0400
Subject: [PATCH] Move policykey generation to the state object

---
 framework/ActiveSync/lib/Horde/ActiveSync/Driver/Base.php | 15 +++------------
 .../ActiveSync/lib/Horde/ActiveSync/Request/Provision.php |  4 ++--
 framework/ActiveSync/lib/Horde/ActiveSync/State/Base.php  | 10 ++++++++++
 3 files changed, 15 insertions(+), 14 deletions(-)

diff --git a/framework/ActiveSync/lib/Horde/ActiveSync/Driver/Base.php b/framework/ActiveSync/lib/Horde/ActiveSync/Driver/Base.php
index b36531386..c08503005 100644
--- a/framework/ActiveSync/lib/Horde/ActiveSync/Driver/Base.php
+++ b/framework/ActiveSync/lib/Horde/ActiveSync/Driver/Base.php
@@ -82,10 +82,11 @@ abstract class Horde_ActiveSync_Driver_Base
     protected $_policies = array(
         'requirePin' => true,
         'computerUnlock' => true,
-        'AEFrequencyType' => 0,
+        'AEFrequencyType' => 1,
+        'AEFrequencyValue' => 5,
         'DeviceWipeThreshold' => 10,
         'CodewordFrequency' => 5,
-        'MinimumPasswordLength' => 4,
+        'MinimumPasswordLength' => 5,
         'PasswordComplexity' => 2,
         );
 
@@ -513,16 +514,6 @@ abstract class Horde_ActiveSync_Driver_Base
     }
 
     /**
-     * Generate a random 10 digit policy key
-     *
-     * @return unknown
-     */
-    public function generatePolicyKey()
-    {
-        return mt_rand(1000000000, 9999999999);
-    }
-
-    /**
      * Return a device wipe status
      *
      * @param string $user
diff --git a/framework/ActiveSync/lib/Horde/ActiveSync/Request/Provision.php b/framework/ActiveSync/lib/Horde/ActiveSync/Request/Provision.php
index 3ed3c28ea..5324de3a5 100644
--- a/framework/ActiveSync/lib/Horde/ActiveSync/Request/Provision.php
+++ b/framework/ActiveSync/lib/Horde/ActiveSync/Request/Provision.php
@@ -156,12 +156,12 @@ class Horde_ActiveSync_Request_Provision extends Horde_ActiveSync_Request_Base
                 $policyStatus = self::STATUS_POLKEYMISM;
             } else {
                 /* Set the final key */
-                $policykey = $this->_driver->generatePolicyKey();
+                $policykey = $state->generatePolicyKey();
                 $state->setPolicyKey($this->_devId, $policykey);
             }
         } elseif (empty($policykey)) {
             // This is phase2 - we need to set the intermediate key
-            $policykey = $this->_driver->generatePolicyKey();
+            $policykey = $state->generatePolicyKey();
             $state->setPolicyKey($this->_devId, $policykey);
         }
 
diff --git a/framework/ActiveSync/lib/Horde/ActiveSync/State/Base.php b/framework/ActiveSync/lib/Horde/ActiveSync/State/Base.php
index 1be7157ff..7b2736277 100644
--- a/framework/ActiveSync/lib/Horde/ActiveSync/State/Base.php
+++ b/framework/ActiveSync/lib/Horde/ActiveSync/State/Base.php
@@ -110,6 +110,16 @@ abstract class Horde_ActiveSync_State_Base
     }
 
     /**
+     * Generate a random 10 digit policy key
+     *
+     * @return unknown
+     */
+    public function generatePolicyKey()
+    {
+        return mt_rand(1000000000, 9999999999);
+    }
+
+    /**
      * Loads the initial state from storage for the specified syncKey and
      * intializes the stateMachine for use.
      *
-- 
2.11.0