From ed41fa01bf2c336b0ec02566177faa420fe178bd Mon Sep 17 00:00:00 2001 From: markt Date: Wed, 4 Aug 2010 21:55:19 +0000 Subject: [PATCH] Extend checkstyle to include checking * imports Fix all current * imports Fix a few other issues along the way - Missing @Override - serialVersionUID git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@982412 13f79535-47bb-0310-9956-ffa450edef68 --- checkstyle.xml | 1 + java/javax/el/CompositeELResolver.java | 3 ++ java/javax/servlet/GenericServlet.java | 9 ++++++ java/javax/servlet/ServletRequestWrapper.java | 36 ++++++++++++++++++++++ java/javax/servlet/ServletResponseWrapper.java | 15 +++++++++ .../servlet/http/HttpServletRequestWrapper.java | 30 ++++++++++++++++++ .../servlet/http/HttpServletResponseWrapper.java | 21 +++++++++++++ java/javax/servlet/jsp/HttpJspPage.java | 6 ++-- java/javax/servlet/jsp/JspPage.java | 2 +- .../servlet/jsp/el/ImplicitObjectELResolver.java | 3 ++ java/javax/servlet/jsp/tagext/BodyContent.java | 3 +- java/javax/servlet/jsp/tagext/BodyTag.java | 3 +- java/javax/servlet/jsp/tagext/BodyTagSupport.java | 4 +++ java/javax/servlet/jsp/tagext/IterationTag.java | 3 +- java/javax/servlet/jsp/tagext/JspFragment.java | 4 ++- .../javax/servlet/jsp/tagext/SimpleTagSupport.java | 5 +++ java/javax/servlet/jsp/tagext/Tag.java | 3 +- java/javax/servlet/jsp/tagext/TagAdapter.java | 9 +++++- java/javax/servlet/jsp/tagext/TagSupport.java | 7 +++++ .../catalina/tribes/transport/nio/NioSender.java | 2 +- java/org/apache/catalina/util/MIME2Java.java | 3 +- java/org/apache/jasper/EmbeddedServletOptions.java | 4 ++- java/org/apache/jasper/compiler/ELNode.java | 5 ++- java/org/apache/jasper/compiler/JasperTagInfo.java | 6 +++- .../apache/jasper/compiler/ScriptingVariabler.java | 10 ++++-- .../apache/jasper/compiler/TagPluginManager.java | 6 ++-- .../apache/jasper/tagplugins/jstl/core/Choose.java | 3 +- .../jasper/tagplugins/jstl/core/ForEach.java | 3 +- .../org/apache/jasper/tagplugins/jstl/core/If.java | 3 +- .../jasper/tagplugins/jstl/core/Otherwise.java | 3 +- .../apache/jasper/tagplugins/jstl/core/When.java | 3 +- .../bcel/classfile/LocalVariableTypeTable.java | 5 ++- .../util/net/DefaultServerSocketFactory.java | 6 ++-- .../tribes/test/channel/TestChannelOptionFlag.java | 6 ++-- .../examples/WEB-INF/classes/CookieExample.java | 13 +++++--- .../WEB-INF/classes/HelloWorldExample.java | 13 +++++--- .../WEB-INF/classes/RequestHeaderExample.java | 13 +++++--- .../WEB-INF/classes/RequestInfoExample.java | 12 +++++--- .../WEB-INF/classes/RequestParamExample.java | 12 +++++--- .../examples/WEB-INF/classes/SessionExample.java | 15 ++++++--- webapps/examples/WEB-INF/classes/cal/Entries.java | 3 +- .../examples/WEB-INF/classes/cal/JspCalendar.java | 3 +- .../examples/WEB-INF/classes/cal/TableBean.java | 3 +- .../CompressionFilterTestServlet.java | 8 +++-- .../WEB-INF/classes/dates/JspCalendar.java | 3 +- .../WEB-INF/classes/examples/ExampleTagBase.java | 7 +++-- .../examples/WEB-INF/classes/examples/FooTag.java | 4 ++- .../WEB-INF/classes/examples/FooTagExtraInfo.java | 4 ++- .../examples/WEB-INF/classes/examples/LogTag.java | 6 ++-- .../WEB-INF/classes/examples/ShowSource.java | 12 +++++--- .../WEB-INF/classes/examples/ValuesTag.java | 8 +++-- webapps/examples/WEB-INF/classes/servletToJsp.java | 5 ++- webapps/examples/WEB-INF/jsp/applet/Clock2.java | 13 +++++--- webapps/examples/jsp/plugin/applet/Clock2.java | 11 ++++--- 54 files changed, 321 insertions(+), 82 deletions(-) diff --git a/checkstyle.xml b/checkstyle.xml index 4a4f8efa4..17e1ed97d 100644 --- a/checkstyle.xml +++ b/checkstyle.xml @@ -32,6 +32,7 @@ +