From f38cedebd18dc7368a648037d036badc4f3f723c Mon Sep 17 00:00:00 2001
From: Jan Schneider <jan@horde.org>
Date: Sat, 26 Jun 2010 00:49:34 +0200
Subject: [PATCH] Fix link encoding, use Horde_Url#link().

---
 framework/Core/lib/Horde/Help.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/framework/Core/lib/Horde/Help.php b/framework/Core/lib/Horde/Help.php
index c68b9cd7c..fb006a5eb 100644
--- a/framework/Core/lib/Horde/Help.php
+++ b/framework/Core/lib/Horde/Help.php
@@ -213,9 +213,9 @@ class Horde_Help
             return '';
         }
 
-        $url = Horde::getServiceLink('help', $module)->add('topic', $topic)->setRaw(true);
-        return Horde::link($url, _("Help"), 'helplink', 'hordehelpwin', Horde::popupJs($url, array('urlencode' => true)) . 'return false;') .
-            Horde::img('help.png', _("Help"), 'width="16" height="16"') . '</a>';
+        $url = Horde::getServiceLink('help', $module)->add('topic', $topic);
+        return $url->link(array('title' => _("Help"), 'class' => 'helplink', 'target' => 'hordehelpwin', 'onclick' => Horde::popupJs($url, array('urlencode' => true)) . 'return false;'))
+            . Horde::img('help.png', _("Help")) . '</a>';
     }
 
 
-- 
2.11.0