From f432cd976197eb8bebd9d243ef2663bf26a8d64f Mon Sep 17 00:00:00 2001 From: markt Date: Wed, 14 Jan 2009 20:45:28 +0000 Subject: [PATCH] Remove 1.4 impl since we must be using a 1.6 JVM. git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@734506 13f79535-47bb-0310-9956-ffa450edef68 --- java/org/apache/catalina/tribes/io/BufferPool.java | 10 +--- .../catalina/tribes/io/BufferPool14Impl.java | 69 ---------------------- 2 files changed, 3 insertions(+), 76 deletions(-) delete mode 100644 java/org/apache/catalina/tribes/io/BufferPool14Impl.java diff --git a/java/org/apache/catalina/tribes/io/BufferPool.java b/java/org/apache/catalina/tribes/io/BufferPool.java index 1efbe0151..6b8d3d61e 100644 --- a/java/org/apache/catalina/tribes/io/BufferPool.java +++ b/java/org/apache/catalina/tribes/io/BufferPool.java @@ -61,16 +61,12 @@ public class BufferPool { BufferPoolAPI pool = null; Class clazz = null; try { + // TODO Is this approach still required? clazz = Class.forName("org.apache.catalina.tribes.io.BufferPool15Impl"); pool = (BufferPoolAPI)clazz.newInstance(); } catch ( Throwable x ) { - try { - clazz = Class.forName("org.apache.catalina.tribes.io.BufferPool14Impl"); - pool = (BufferPoolAPI)clazz.newInstance(); - } catch ( Throwable e ) { - log.warn("Unable to initilize BufferPool, not pooling XByteBuffer objects:"+x.getMessage()); - if ( log.isDebugEnabled() ) log.debug("Unable to initilize BufferPool, not pooling XByteBuffer objects:",x); - } + log.warn("Unable to initilize BufferPool, not pooling XByteBuffer objects:"+x.getMessage()); + if ( log.isDebugEnabled() ) log.debug("Unable to initilize BufferPool, not pooling XByteBuffer objects:",x); } pool.setMaxSize(DEFAULT_POOL_SIZE); log.info("Created a buffer pool with max size:"+DEFAULT_POOL_SIZE+" bytes of type:"+(clazz!=null?clazz.getName():"null")); diff --git a/java/org/apache/catalina/tribes/io/BufferPool14Impl.java b/java/org/apache/catalina/tribes/io/BufferPool14Impl.java deleted file mode 100644 index d31254807..000000000 --- a/java/org/apache/catalina/tribes/io/BufferPool14Impl.java +++ /dev/null @@ -1,69 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ -package org.apache.catalina.tribes.io; - -import java.util.LinkedList; - - -/** - * - * @author Filip Hanik - * @version 1.0 - */ -class BufferPool14Impl implements BufferPool.BufferPoolAPI { - protected int maxSize; - protected int size = 0; - protected LinkedList queue = new LinkedList(); - - public void setMaxSize(int bytes) { - this.maxSize = bytes; - } - - public synchronized int addAndGet(int val) { - size = size + (val); - return size; - } - - - - public synchronized XByteBuffer getBuffer(int minSize, boolean discard) { - XByteBuffer buffer = (XByteBuffer)(queue.size()>0?queue.remove(0):null); - if ( buffer != null ) addAndGet(-buffer.getCapacity()); - if ( buffer == null ) buffer = new XByteBuffer(minSize,discard); - else if ( buffer.getCapacity() <= minSize ) buffer.expand(minSize); - buffer.setDiscard(discard); - buffer.reset(); - return buffer; - } - - public synchronized void returnBuffer(XByteBuffer buffer) { - if ( (size + buffer.getCapacity()) <= maxSize ) { - addAndGet(buffer.getCapacity()); - queue.add(buffer); - } - } - - public synchronized void clear() { - queue.clear(); - size = 0; - } - - public int getMaxSize() { - return maxSize; - } - -} -- 2.11.0