From f47d1052eae37d542155791fb06a127c4b553f36 Mon Sep 17 00:00:00 2001 From: Chuck Hagenbuch Date: Sat, 21 Aug 2010 23:11:19 -0400 Subject: [PATCH] Make getRandomGallery() actually random --- ansel/lib/Storage.php | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/ansel/lib/Storage.php b/ansel/lib/Storage.php index 123ed4ee1..6dd5c3582 100644 --- a/ansel/lib/Storage.php +++ b/ansel/lib/Storage.php @@ -938,18 +938,13 @@ class Ansel_Storage public function getRandomGallery($params = array()) { $params = new Horde_Support_Array($params); - $num_galleries = $this->countGalleries($GLOBALS['registry']->getAuth(), - $params->perm, - $params->filter, - $params->parent, - $params->allLevels); - if (!$num_galleries) { - return $num_galleries; - } $galleries = $this->listGalleries($params); - $gallery = array_pop($galleries); + if (!$galleries) { + return false; + } - return $gallery; + $gallery_key = array_rand($galleries); + return $galleries[$gallery_key]; } /** -- 2.11.0