From f9f9989efb7de69f135c91aa9707a628b3551dbb Mon Sep 17 00:00:00 2001
From: markt <markt@13f79535-47bb-0310-9956-ffa450edef68>
Date: Sun, 31 Jan 2010 13:42:09 +0000
Subject: [PATCH] Test case for RequestUtil. Current implementation does not
 agree with comment.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@905039 13f79535-47bb-0310-9956-ffa450edef68
---
 test/org/apache/catalina/util/TestRequestUtil.java | 43 ++++++++++++++++++++++
 1 file changed, 43 insertions(+)
 create mode 100644 test/org/apache/catalina/util/TestRequestUtil.java

diff --git a/test/org/apache/catalina/util/TestRequestUtil.java b/test/org/apache/catalina/util/TestRequestUtil.java
new file mode 100644
index 000000000..51ea934a9
--- /dev/null
+++ b/test/org/apache/catalina/util/TestRequestUtil.java
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ * 
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.catalina.util;
+
+import junit.framework.TestCase;
+
+public class TestRequestUtil extends TestCase {
+
+    public void testURLDecodeString() {
+        // %n rather than %nn should throw an IAE according to the Javadoc
+        Exception exception = null;
+        try {
+            RequestUtil.URLDecode("%5xxxxx");
+        } catch (Exception e) {
+            exception = e;
+        }
+        assertTrue(exception instanceof IllegalArgumentException);
+
+        // Edge case trying to trigger ArrayIndexOutOfBoundsException
+        exception = null;
+        try {
+            RequestUtil.URLDecode("%5");
+        } catch (Exception e) {
+            exception = e;
+        }
+        assertTrue(exception instanceof IllegalArgumentException);
+    }
+}
-- 
2.11.0