From feb0fe4eaa81954ec84c80b1700c8d03437c742a Mon Sep 17 00:00:00 2001 From: markt Date: Sun, 10 Apr 2011 10:33:30 +0000 Subject: [PATCH] Improve error reporting by labeling line/column numbers git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1090763 13f79535-47bb-0310-9956-ffa450edef68 --- java/org/apache/jasper/compiler/DefaultErrorHandler.java | 4 ++-- webapps/docs/changelog.xml | 14 +++++++++++--- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/java/org/apache/jasper/compiler/DefaultErrorHandler.java b/java/org/apache/jasper/compiler/DefaultErrorHandler.java index f12ff5fa1..c55082246 100644 --- a/java/org/apache/jasper/compiler/DefaultErrorHandler.java +++ b/java/org/apache/jasper/compiler/DefaultErrorHandler.java @@ -38,8 +38,8 @@ class DefaultErrorHandler implements ErrorHandler { @Override public void jspError(String fname, int line, int column, String errMsg, Exception ex) throws JasperException { - throw new JasperException(fname + "(" + line + "," + column + ")" - + " " + errMsg, ex); + throw new JasperException(fname + "(line: " + line + ", column: " + + column + ")" + " " + errMsg, ex); } /* diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index bdf44f3ab..19474d821 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -57,9 +57,9 @@ separated by commas. (kkolinko) - 50306: New StuckThreadDetectionValve to detect requests that take a - long time to process, which might indicate that their processing threads are - stuck. Based on a patch provided by TomLu. (slaurent) + 50306: New StuckThreadDetectionValve to detect requests that + take a long time to process, which might indicate that their processing + threads are stuck. Based on a patch provided by TomLu. (slaurent) @@ -71,6 +71,14 @@ + + + + Label JSP/tag file line and column numbers when reporting errors since + it may not be immediately obvious what the numbers represent. (markt) + + + -- 2.11.0